Skip to content

UI: Output timer bug #10937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Sugam-Chand-M wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UI: Output timer bug #10937

Sugam-Chand-M wants to merge 1 commit into from

Conversation

@Sugam-Chand-M
Copy link

@Sugam-Chand-M Sugam-Chand-M commented Jul 1, 2024

Description

Output Timer for Recording dosen't update from Stop -> Start even after the timer expires when the Output Timer dialog is closed.
Issue - #10900

Motivation and Context

This PR aims at proper updating of buttons when the timer is expired and even when the Dialog is closed.
Fixes the Issue - #10900

How Has This Been Tested?

Tested manually in Windows 11.
Added a video drive link - Video Link of the fix working

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@ShaMAD
Copy link

ShaMAD commented Jul 4, 2024

The same bug is on streaming timer.

...
void OutputTimer::StreamTimerStop()
{
streamingAlreadyActive = false;
if (!isVisible() && streamingTimer->isActive() == false)
return;
if (streamingTimer->isActive())
...

@Sugam-Chand-M Sugam-Chand-M force-pushed the issueFix-10900 branch 3 times, most recently from 3d36cf1 to 1dceaad Compare July 6, 2024 13:04
@Lain-B Lain-B added this to the OBS Studio 31 milestone Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

OBS Studio 31.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Sugam-Chand-M @ShaMAD @Lain-B